Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instruments >:) #717

Merged
merged 5 commits into from
Aug 2, 2024
Merged

Add instruments >:) #717

merged 5 commits into from
Aug 2, 2024

Conversation

toberge
Copy link
Contributor

@toberge toberge commented Jun 8, 2024

wth does this do

  • Closes Instruments for a full Wild Metal Band >:) #716 and thus adds a bunch of new props and animations 🎉
  • Adds instrumentbots to crater town and the pit, shooting them distorts the music
  • Adds instrumentbots and a piano player to the main menu
  • Adds a piano to the auction stage
  • Adds a scene with the full band and a render camera for the album cover
  • Adds a script for writing render textures to file

Future plans/needs

  • Fix color encoding in render texture writing script
  • Adjust animation speed to follow the beat of the currently playing song (for horn- and trumpetbot only)
  • Add victory screen with band members and some pedestals and stuff, see Victory screen (?)  #638

@toberge toberge force-pushed the feature/instruments branch 11 times, most recently from ebb78ee to 55e0946 Compare July 20, 2024 14:29
@toberge toberge force-pushed the feature/instruments branch 10 times, most recently from f79da4c to 6e57ebe Compare July 23, 2024 16:58
@toberge toberge force-pushed the feature/instruments branch 2 times, most recently from 1a1dc0e to 256b48f Compare August 1, 2024 16:58
@toberge toberge marked this pull request as ready for review August 1, 2024 19:36
Copy link
Contributor

@Fueredoriku Fueredoriku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The band is very cute, and it's so funny that we finally added this 😁

I have some general feedback, but there is nothing major, so I'll leave an approve for you to use at your discretion 👍

General feedback:

  • I think the band could use a name! Maybe add a loadingscreen tip where you say something like "did you know the music is played by insert band name here "
  • The hornbot animation no longer produces particles. It seems that maybe the animation may have lost the "set active"-toggles of the gameobjects that contain the exhaust particles? 🤔
  • For the main menu, while the scales technically are correct, I think adjusting the size or placement of the piano+cowbot so the size looks more comparatively correct to the barrels (which look much larger than they actually are in game).
    image

Assets/Scripts/Utils/RenderTextureActions.cs Outdated Show resolved Hide resolved
@toberge toberge force-pushed the feature/instruments branch 2 times, most recently from 0a6b136 to 87c2f41 Compare August 2, 2024 19:17
@toberge toberge merged commit ff24d55 into dev Aug 2, 2024
@toberge toberge deleted the feature/instruments branch August 2, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

Instruments for a full Wild Metal Band >:)
2 participants