-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instruments >:) #717
Merged
Merged
Add instruments >:) #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebb78ee
to
55e0946
Compare
f79da4c
to
6e57ebe
Compare
6e57ebe
to
50b5fac
Compare
1a1dc0e
to
256b48f
Compare
34bca6c
to
a99611b
Compare
Fueredoriku
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The band is very cute, and it's so funny that we finally added this 😁
I have some general feedback, but there is nothing major, so I'll leave an approve for you to use at your discretion 👍
General feedback:
- I think the band could use a name! Maybe add a loadingscreen tip where you say something like "did you know the music is played by insert band name here "
- The hornbot animation no longer produces particles. It seems that maybe the animation may have lost the "set active"-toggles of the gameobjects that contain the exhaust particles? 🤔
- For the main menu, while the scales technically are correct, I think adjusting the size or placement of the piano+cowbot so the size looks more comparatively correct to the barrels (which look much larger than they actually are in game).
0a6b136
to
87c2f41
Compare
87c2f41
to
ef7c4d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wth does this do
Future plans/needs